Hi! On 2021-05-06 16:00, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > As Peter points out, if we were to disconnect and then reconnect this > driver from a device, the "global" state of the device would contain odd > values and could cause problems. Fix this up by just initializing the > whole thing to 0 at probe() time. > > Ideally this would be a per-device variable, but given the age and the > total lack of users of it, that would require a lot of s/./->/g changes > for really no good reason. > > Reported-by: Peter Rosin <peda@xxxxxxxxxx> > Cc: Jens Axboe <axboe@xxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Looks good to me. Reviewed-by: Peter Rosin <peda@xxxxxxxxxx> Thanks, Peter
