Re: [PATCH V3] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators

[Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx>]

From: Marek Vasut [mailto:marex@xxxxxxx]
Sent: Monday, April 26, 2021 12:23 PM

> Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1
> via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied
> from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs.
> 
> While no instability or problems are currently observed, the regulators
> should be fully described in DT and that description should fully match
> the hardware, else this might lead to unforseen issues later. Fix this.
> 
> Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM
> and PDK2")
> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> Cc: Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: Ludwig Zenz <lzenz@xxxxxxxxxxxxxxxxxx>
> Cc: NXP Linux Team <linux-imx@xxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> ---
> V2: Amend commit message
> V3: Reinstate the missing SoB line, add RB
> ---
>  arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> index 236fc205c389..d0768ae429fa 100644
> --- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> +++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> @@ -406,6 +406,18 @@ &reg_soc {
>         vin-supply = <&sw1_reg>;
>  };
> 
> +&reg_pu {
> +       vin-supply = <&sw1_reg>;
> +};
> +
> +&reg_vdd1p1 {
> +       vin-supply = <&sw2_reg>;
> +};
> +
> +&reg_vdd2p5 {
> +       vin-supply = <&sw2_reg>;
> +};
> +
>  &uart1 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_uart1>;
> --
> 2.30.2

Reviewed-by: Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx>