On Wed, Apr 21, 2021 at 06:30:07PM +0200, Takashi Iwai wrote: > On Wed, 21 Apr 2021 15:01:02 +0200, > Greg Kroah-Hartman wrote: > > > > This reverts commit 3f12888dfae2a48741c4caa9214885b3aaf350f9. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Wenwen Wang <wang6495@xxxxxxx> > > Cc: <stable@xxxxxxxxxxxxxxx> > > Cc: Takashi Iwai <tiwai@xxxxxxx> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > This one is, unlike other patches I've been involved with, about the > ALSA core code, and this change is likely worth to keep. > > The code change is correct, and even though it's really a minor issue, > an optimization is right. Thanks for the review, now dropped. greg k-h