Hi Marek, On Fri, Apr 23, 2021 at 2:57 PM Marek Vasut <marex@xxxxxxx> wrote: > > Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1 > via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied > from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs. > > While no instability or problems are currently observed, the regulators > should be fully described in DT and that description should fully match > the hardware, else this might lead to unforseen issues later. Fix this. > > Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2") > Cc: Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx> > Cc: Fabio Estevam <festevam@xxxxxxxxx> > Cc: Ludwig Zenz <lzenz@xxxxxxxxxxxxxxxxxx> > Cc: NXP Linux Team <linux-imx@xxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx You missed your Signed-off-by tag. With that added: Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>