On Fri, 23 Apr 2021 11:50:51 +0100, Mark Rutland <mark.rutland@xxxxxxx> wrote: [...] > > Fixes: 17ce302f3117 ("arm64: Fix interrupt tracing in the presence of NMIs") > > Signed-off-by: He Ying <heying24@xxxxxxxxxx> > > I'm reckon the fixes tag should probably be either: > > Fixes: f32c926651dcd168 ("irqchip/gic-v3: Handle pseudo-NMIs") > > ... or: > > Fixes: 3f1f3234bc2db1c1 (" irqchip/gic-v3: Switch to PMR masking before calling IRQ handler") > > ... since the underlying issue is that gic_handle_irq() unmasks DAIF.I > and permits unintended nesting, even if that doesn't trigger a BUG() at > that point. I used the latter (see 161917211934.29796.1841651233234902273.tip-bot2@tip-bot2). > Otherwise, this makes sense to me: > > Acked-by: Mark Rutland <mark.rutland@xxxxxxx> I'll update the commit to reflect this. Thanks. M. -- Without deviation from the norm, progress is not possible.