On 13/04/2021 10:27, Greg KH wrote: > On Mon, Apr 12, 2021 at 10:46:41PM +0300, Zidenberg, Tsahi wrote: >> The original bug that I was working on: command line parameters don't >> appear when snooping execve using bpf on arm64. > Has this ever worked? If not, it's not really a regression that needs > to be fixed, just use a newer kernel version, right? It's not so much a regression between old and new kernels, as it is a regression when changing architectures. The same API works on x86, but not on arm64 (in x86 - you can access userspace with a kernelspace access). Multiple Linux distributions support both x86 and arm64, and some of these choose to keep with 5.4 LTS Linux kernel. I think these distributions should expect the same experience across architectures. > But your "patch 1" is no where near what that commit is upstream so now > you have divered from what is there and created something new. And we > don't like that for obvious reasons (no testing, maintaining over time, > etc.) I have created an alternative patch series that stays very close to upstream. It brings in much more code, and adds some APIs as we discussed. Will send it right away for your consideration. Thank you! Tsahi.