Re: [PATCH] mac80211: fix suspend vs. association race

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2014-05-13 at 12:54 +0300, Emmanuel Grumbach wrote:
> If the association is in progress while we suspend, the
> stack will be in a messed up state. Clean it before we
> suspend.
> 
> This patch completes Johannes's patch:
> 
> 1a1cb744de160ee70086a77afff605bbc275d291
> Author: Johannes Berg <johannes.berg@xxxxxxxxx>
> 
>     mac80211: fix suspend vs. authentication race
> 
> Cc: <stable@xxxxxxxxxxxxxxx>
> Fixes: 12e7f517029d ("mac80211: cleanup generic suspend/resume procedures")
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> ---
>  net/mac80211/mlme.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 139005d..5e4f7ea 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -3600,7 +3600,7 @@ void ieee80211_mgd_quiesce(struct ieee80211_sub_if_data *sdata)
>  
>  	sdata_lock(sdata);
>  
> -	if (ifmgd->auth_data) {
> +	if (ifmgd->auth_data || ifmgd->assoc_data) {

This can crash if auth_data is NULL (but we use it to build the deauth)
- I'm rolling in a fix for that.

johannes

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]