On Thu, Apr 15, 2021 at 10:54:17AM -0700, Guenter Roeck wrote: > On Thu, Apr 15, 2021 at 10:49:50AM -0700, Guenter Roeck wrote: > > On Thu, Apr 15, 2021 at 06:37:41PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Apr 15, 2021 at 09:28:15AM -0700, Guenter Roeck wrote: > > > > Hi Greg, > > > > > > > > please consider applying the following two patches to v4.4.y, v4.9.y, and v4.14.y > > > > > > > > 80055dab5de0 ("netfilter: x_tables: make xt_replace_table wait until old rules are not used anymore") > > > > 175e476b8cdf ("netfilter: x_tables: Use correct memory barriers.") > > > > > > The second patch here says that it's only needed to go back until: > > > Fixes: 7f5c6d4f665b ("netfilter: get rid of atomic ops in fast path") > > > > > > Which is only backported to 4.19. So why do older kernels need that, is > > > the fixes tag wrong? > > > > > > > Outch, it looks like 80055dab5de0 was fixed later with cc00bcaa5899, which in > > turn was fixed with 443d6e86f821. Ok, back to the drawing board, but it may > > just be easier to forget about this. I'll let you know. > > > I tried to apply cc00bcaa5899 on top of the above, and got lots of conflicts. > Please ignore this request; it adds more risk than gain. Sorry for the noise. No worries, now ignored :)