On Wed, Apr 07, 2021 at 04:18:30PM -0700, Sagi Grimberg wrote: > > > > > > Hence, we need to fix all the kernels that were before submit_bio_noacct was > > > > > introduced. > > > > > > > > Why can we not just add submit_bio_noacct to the 5.4 kernel to correct > > > > this? What commit id is that? > > > > > > Hey Greg, > > > > > > submit_bio_noacct was applied as part of a rework by Christoph that I > > > didn't feel was suitable as a stable candidate. The commit-id is: > > > ed00aabd5eb9fb44d6aff1173234a2e911b9fead > > > > submit_bio_noacct really is just a new name for generic_make_request, > > as the old one was horribly misleading. So this does use > > submit_bio_noacct, just with its old name. > > commit ed00aabd5eb9fb44d6aff1173234a2e911b9fead does not apply > cleanly on any of these kernels, so I think it's better to take this > small one-liner instead of trying to fit a commit that changes the > name treewide. > > Greg, what is your preference? backporting > ed00aabd5eb9fb44d6aff1173234a2e911b9fead to the various kernels > or to take this isolated one? I took just this change now, thanks. greg k-h
