Re: [PATCH V2 v5.4 1/8] driver core: add a min_align_mask field to struct device_dma_parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 06, 2021 at 08:43:20PM +0000, Jianxiong Gao wrote:
> 'commit 36950f2da1ea ("driver core: add a min_align_mask field to struct device_dma_parameters")'
> 
> Some devices rely on the address offset in a page to function
> correctly (NVMe driver as an example). These devices may use
> a different page size than the Linux kernel. The address offset
> has to be preserved upon mapping, and in order to do so, we
> need to record the page_offset_mask first.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Acked-by: Jianxiong Gao <jxgao@xxxxxxxxxx>
> Tested-by: Jianxiong Gao <jxgao@xxxxxxxxxx>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Signed-off-by: Jianxiong Gao <jxgao@xxxxxxxxxx>
> ---
>  include/linux/device.h      |  1 +
>  include/linux/dma-mapping.h | 16 ++++++++++++++++
>  2 files changed, 17 insertions(+)

The signed-off-by area is still not correct with what is in Linus's
tree, how did you create this thing?

That does not bode well, so I'm dropping this whole series, see my
comments on the 5.10 series for details.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux