Re: [PATCH] platform/chrome: Update cros_ec sysfs attributes on sensors discovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gwendal,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on chrome-platform-linux/for-next]
[also build test WARNING on linux/master linus/master v5.12-rc5 next-20210401]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gwendal-Grignou/platform-chrome-Update-cros_ec-sysfs-attributes-on-sensors-discovery/20210403-142205
base:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
config: riscv-randconfig-s032-20210403 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-279-g6d5d9b42-dirty
        # https://github.com/0day-ci/linux/commit/f4bc64b0efbd2fb964478a0a2aab4ba2fc827447
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Gwendal-Grignou/platform-chrome-Update-cros_ec-sysfs-attributes-on-sensors-discovery/20210403-142205
        git checkout f4bc64b0efbd2fb964478a0a2aab4ba2fc827447
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)
>> drivers/platform/chrome/cros_ec_sysfs.c:348:31: sparse: sparse: incorrect type in assignment (different modifiers) @@     expected struct attribute_group *group @@     got struct attribute_group const * @@
   drivers/platform/chrome/cros_ec_sysfs.c:348:31: sparse:     expected struct attribute_group *group
   drivers/platform/chrome/cros_ec_sysfs.c:348:31: sparse:     got struct attribute_group const *

vim +348 drivers/platform/chrome/cros_ec_sysfs.c

   337	
   338	static int cros_ec_sysfs_probe(struct platform_device *pd)
   339	{
   340		struct cros_ec_dev *ec_dev = dev_get_drvdata(pd->dev.parent);
   341		struct device *dev = &pd->dev;
   342		int ret;
   343	
   344		ret = sysfs_create_group(&ec_dev->class_dev.kobj, &cros_ec_attr_group);
   345		if (ret < 0)
   346			dev_err(dev, "failed to create attributes. err=%d\n", ret);
   347		else
 > 348			ec_dev->group = &cros_ec_attr_group;
   349	
   350		return ret;
   351	}
   352	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux