Re: [PATCH stable] powerpc/tm: Add missing TEXASR_FS #define

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 09, 2014 at 10:52:08AM -0700, Guenter Roeck wrote:
> On Fri, May 09, 2014 at 04:48:31AM +0200, Greg Kroah-Hartman wrote:
> > On Fri, May 09, 2014 at 09:28:58AM +1000, Michael Neuling wrote:
> > > On Thu, 2014-05-08 at 06:52 -0700, Guenter Roeck wrote:
> > > > On 05/07/2014 10:52 PM, Michael Neuling wrote:
> > > > > On Wed, 2014-05-07 at 22:00 -0700, Guenter Roeck wrote:
> > > > >> Both 3.10 and 3.14 are affected.
> > > > >>
> > > > >> powerpc:defconfig, powerpc:allmodconfig:
> > > > >>
> > > > >> arch/powerpc/kernel/signal_32.c: In function 'restore_tm_user_regs':
> > > > >> arch/powerpc/kernel/signal_32.c:867:31: error: 'TEXASR_FS' undeclared (first use in this function)
> > > > >> arch/powerpc/kernel/signal_32.c:867:31: note: each undeclared identifier is reported only once for each function it appears in
> > > > >> make[1]: *** [arch/powerpc/kernel/signal_32.o] Error 1
> > > > >>
> > > > >> Due to 'powerpc/tm: Disable IRQ in tm_recheckpoint' which uses the above define
> > > > >> without defining it. TEXASR_FS is defined with commit e4e381215 (KVM: PPC: Book3S
> > > > >> HV: Add transactional memory support) upstream.
> > > > >
> > > > > Argh, bugger.
> > > > >
> > > > > The below should fix both trees.  It's just the #define from upstream
> > > > > e4e38121507a27d2ccc4b28d9e7fc4818a12c44c (we don't want the rest of that patch
> > > > > in stable as it's not a fix).
> > > > >
> > > > 
> > > > It would probably be better to merge it into the other patch, as it is really
> > > > part of the back-port (and bisect would be broken otherwise for the affected
> > > > images).
> > > 
> > > 
> > > In case it's useful, here's merged patch which should replace the existing one.
> > 
> > Thanks, I've added the one line so all should be well.
> > 
> 
> Did you miss to update 3.14, by any chance ?
> I see the problem fixed in 3.10, but 3.14 still fails.

Oops, I didn't realize 3.14 needed it too, now fixed up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]