On Thu, 4 Mar 2021 12:43:44 -0500 Tony Krowiak <akrowiak@xxxxxxxxxxxxx> wrote: > On the other hand, if we don't have ->kvm because something broke, > then we may be out of luck anyway. There will certainly be no > way to unregister the GISC; however, it may still be possible > to unpin the pages if we still have q->saved_pfn. > > The point is, if the queue is bound to vfio_ap, it can be reset. If we can't > clean up the IRQ resources because something is broken, then there > is nothing we can do about that. Especially since the recently added WARN_ONCE macros calling reset_queues unconditionally ain't that bad: we would at least see if there is a problem with cleaning up the IRQ resources. Let's make it unconditional again and observe. Can you send out a v4 with this and the other issue fixed. Regards, Halil
