Re: [PATCH] posix_acl: handle NULL ACL in posix_acl_equiv_mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 04, 2014 at 01:03:32PM +0200, Christoph Hellwig wrote:
> Various filesystems don't bother checking for a NULL ACL in
> posix_acl_equiv_mode, and thus can dereference a NULL pointer when it
> gets passed one. This usually happens from the NFS server, as the ACL tools
> never pass a NULL ACL, but instead of one representing the mode bits.
> 
> Instead of adding boilerplat to all filesystems put this check into one place,
> which will allow us to remove the check from other filesystems as well later
> on.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reported-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> Reported-by: Marco Munderloh <munderl@xxxxxxxxxxxxxxxxxxx>,
> Cc: Chuck Lever <chuck.lever@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Reviewed-by: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]