On Tue, 23 Feb 2021 at 21:49, Heiko Stuebner <heiko@xxxxxxxxx> wrote: > On Tue, 11 Aug 2020 16:26:31 -0400, Alyssa Rosenzweig wrote: > > The AFBC decoder used in the Rockchip VOP assumes the use of the > > YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) > > buffers, which covers the RGBA8 and RGB565 formats supported in > > vop_convert_afbc_format. Use of YTR is signaled with the > > AFBC_FORMAT_MOD_YTR modifier, which prior to this commit was missing. As > > such, a producer would have to generate buffers that do not use YTR, > > which the VOP would erroneously decode as YTR, leading to severe visual > > corruption. > > Applied, thanks! > > [1/1] drm/rockchip: Require the YTR modifier for AFBC > commit: 0de764474e6e0a74bd75715fed227d82dcda054c Thanks Heiko!