On Mon, Feb 22, 2021 at 03:33:01PM -0600, Pierre-Louis Bossart wrote:
> cppcheck warning:
>
> sound/soc/samsung/tm2_wm5110.c:605:6: style: Variable 'ret' is
> reassigned a value before the old one has been
> used. [redundantAssignment]
> ret = devm_snd_soc_register_component(dev, &tm2_component,
> ^
> sound/soc/samsung/tm2_wm5110.c:554:7: note: ret is assigned
> ret = of_parse_phandle_with_args(dev->of_node, "i2s-controller",
> ^
> sound/soc/samsung/tm2_wm5110.c:605:6: note: ret is overwritten
> ret = devm_snd_soc_register_component(dev, &tm2_component,
> ^
>
> The args is a stack variable, so it could have junk (uninitialized)
> therefore args.np could have a non-NULL and random value even though
> property was missing. Later could trigger invalid pointer dereference.
>
> This patch provides the correct fix, there's no need to check for
> args.np because args.np won't be initialized on errors.
>
> Fixes: 75fa6833aef3 ("ASoC: samsung: tm2_wm5110: check of_parse return value")
> Fixes: 8d1513cef51a ("ASoC: samsung: Add support for HDMI audio on TM2board")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Suggested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Best regards,
Krzysztof
