On Sun, 21 Feb 2021 01:10:57 +0100 Andrew Lunn <andrew@xxxxxxx> wrote: > On Sun, Feb 21, 2021 at 12:11:44AM +0100, Marek Behún wrote: > > Use the `marvell,reg-init` DT property to configure the LED[2]/INTn pin > > of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode. > > > > Without this the pin is by default in LED[2] mode, and the Marvell PHY > > driver configures LED[2] into "On - Link, Blink - Activity" mode. > > > > This fixes the issue where the pca9538 GPIO/interrupt controller (which > > can't mask interrupts in HW) received too many interrupts and after a > > time started ignoring the interrupt with error message: > > IRQ 71: nobody cared > > Hi Marek > > The pca9538 and alike are a poor choice for interrupts. As you said, > you cannot mask interrupts, and input are interrupt sources. > > With this change, does it actually work reliably? It looks like all > the inputs you have support polling. And because this devices is so > unreliable with interrupts, interrupt support is mostly not built. I > would not expect a distribution kernel to enable interrupt support for > this driver. Does all the code correctly fall back to polling when > interrupts are not available? > > So although the patch looks O.K, i'm just wonder if it is worth it, or > the better fix is to remove the interrupt configuration from the > pca9538 node. > > Andrew Hi Andrew, - we already discussed this and you explained to me that pca9538 is poor as an interrupt source. That is why I did not send patch adding interrupt-source to the PHY node last time. We are polling the PHY for interrupts for now - I would like to try this though, and see whether it will cause problems. Unfortunately I forgot to do this last time - nonetheless the pin is connected as an interrupt on the board, so I think that the PHY driver should configure it that way, even if the INT signal is not used - removing the interrupts property from the pca9538 controller node would solve the issue as well. The other pins on the controller are used for SFP cage GPIOs and the way the pca953x driver is written, the GPIOs are polled anyway - the interrupt is not used for them All in all I think for now this solution is best (since the pin is _meant_ to be used as an interrupt pin on the board and the issue is solved by this patch). BTW do you have some experience where pca9538 or compatible cause errors when used for interrupts? Because I am thinking about trying to update the pca953x driver to support IRQs via the gpio_chip it registers, instead of a separate irq_chip. Marek
