Re: [PATCH] erofs: initialized fields can only be observed after bit is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2021/2/9 21:06, Gao Xiang via Linux-erofs wrote:
From: Gao Xiang <hsiangkao@xxxxxxxxxx>

Currently, although set_bit() & test_bit() pairs are used as a fast-
path for initialized configurations. However, these atomic ops are
actually relaxed forms. Instead, load-acquire & store-release form is
needed to make sure uninitialized fields won't be observed in advance
here (yet no such corresponding bitops so use full barriers instead.)

Fixes: 62dc45979f3f ("staging: erofs: fix race of initializing xattrs of a inode at the same time")
Fixes: 152a333a5895 ("staging: erofs: add compacted compression indexes support")
Cc: <stable@xxxxxxxxxxxxxxx> # 5.3+
Reported-by: Huang Jianan <huangjianan@xxxxxxxx>
Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxx>

Thanks for detailed explanation for barrier offline.

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Thanks,



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux