Re: FAILED: patch "[PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada" failed to apply to 5.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 08 February 2021 15:54:10 Greg KH wrote:
> On Mon, Feb 08, 2021 at 03:37:05PM +0100, Pali Rohár wrote:
> > On Monday 08 February 2021 12:07:09 Pali Rohár wrote:
> > > On Monday 08 February 2021 11:16:20 Greg KH wrote:
> > > > On Mon, Feb 08, 2021 at 11:09:52AM +0100, Greg KH wrote:
> > > > > On Sun, Feb 07, 2021 at 04:56:21PM +0100, Pali Rohár wrote:
> > > > > > On Sunday 07 February 2021 16:30:54 gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > > > > > > The patch below does not apply to the 5.4-stable tree.
> > > > > > > If someone wants it applied there, or to any other stable or longterm
> > > > > > > tree, then please email the backport, including the original git commit
> > > > > > > id to <stable@xxxxxxxxxxxxxxx>.
> > > > > > > 
> > > > > > > thanks,
> > > > > > > 
> > > > > > > greg k-h
> > > > > > ...
> > > > > > > Fixes: bd3d25b07342 ("arm64: dts: marvell: armada-37xx: link USB hosts with their PHYs")
> > > > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 5.1+: ea17a0f153af: phy: marvell: comphy: Convert internal SMCC firmware return codes to errno
> > > > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 5.1+: f768e718911e: usb: host: xhci-plat: add priv quirk for skip PHY initialization
> > > > > > 
> > > > > > Hello Greg! Seems that you have forgot to apply some dependency patches.
> > > > > 
> > > > > You are right, I had one, not the other, now fixed up...
> > > > 
> > > > Nope, of_phy_put(phy) is not present in 5.4, so it needs a "real"
> > > > backport.
> > > > 
> > > > Can you do that?
> > > 
> > > Ok, I will look at it.
> > 
> > Now I have backported this patch to 5.4 version and tested it with old
> > arm trusted firmware (for which this patch is fixing support) and also
> > with the new arm trusted firmware. It is working fine in both cases.
> > 
> > Still this patch depends on two mentioned commits which are required.
> 
> This worked, thanks!
> 
> greg k-h

Perfect!

Just to note for other people, I have tested this backported patch on
linux 5.4 on Espressobin v5 board with "old arm trusted firmware"
version 2017.03-armada-17.10 from http://espressobin.net/tech-spec/

And on 5.4 kernel finally usb 3.0 port started working!

(of course with new arm trusted firmware compiled from source code there
is no such issue, but Espressobin comes with burned above old firmware
version)



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux