On Fri, 2014-05-02 at 10:07 -0700, Kamal Mostafa wrote: > Dirk Behme points out that this "Cc: stable" commit breaks the > lttng-modules userspace API when applied to stable kernels. Stable > versions 3.2, 3.8, 3.11, and 3.13 (at least) have all queued it: > > af5040da01ef980670b3741b3e10733ee3e33566 > blktrace: fix accounting of partially completed requests > > > On Thu, 2014-05-01 at 10:28 +0200, Dirk Behme wrote: > > [...] might break the build of the user space lttng-modules > > (lttng-probe-block.c) due the the API change of > > trace_block_rq_complete(). > > > [...] On the other hand, looking into the lttng-modules git > > http://git.lttng.org/?p=lttng-modules.git;a=commitdiff;h=1c53e689434a6bdd7dc3f54c07bfb72750d1d24c > > looks like this is the necessary user space adaption to the kernel > > change? So this looks like that lttng-modules expects a KERNEL_VERSION > > >= (3,15,0) to have this commit? The event structure and string format seem to be unchanged. The event structure is only filled out with different code, i.e. using the number of bytes already completed rather than the total number requested. Ben. > My inclination is that we probably need to revert/drop "af5040d > blktrace: fix accounting..." from the stable kernels to unbreak the > userspace API. > > I'm looking for opinions and advice from other stable maintainers and/or > lttng folks. > > -Kamal > -- Ben Hutchings Lowery's Law: If it jams, force it. If it breaks, it needed replacing anyway.
Attachment:
signature.asc
Description: This is a digitally signed message part