Forgot to mention that this patch set shall be directly applied to 4.19
stable, though this issue should be fixed for all currently maintained
stable trees, from stable #4.4+.
--
Thanks,
Jeffle
On 2/7/21 7:46 PM, Jeffle Xu wrote:
> The upstream commit fef912bf860e8e7e48a2bfb978a356bba743a8b7 ("block:
> genhd: add 'groups' argument to device_add_disk") and the following
> patches fix a race condition of udev for several devices, including
> nvme, aoe, zram and virtio.
>
> The stable tree commit 9e07f4e243791e00a4086ad86e573705cf7b2c65("zram:
> close udev startup race condition as default groups") only fixes zram,
> leaving other devices unfixed.
>
> This udev race issue indeed makes trouble. We recently found that this
> issue can cause missing '/dev/disk/by-id/XXXX' symlink of virtio-blk
> devices on 4.19.
>
> Be noted that this patch set follows the idea of stable commit
> 9e07f4e243791e00a4086ad86e573705cf7b2c65 ("zram: close udev startup race
> condition as default groups") of merging the preparation patch (commit
> fef912bf860e) and the fixing patch (commit 98af4d4df889).
>
> Jeffle Xu (3):
> virtio-blk: close udev startup race condition as default groups
> aoe: close udev startup race condition as default groups
> nvme: close udev startup race condition as default groups
>
> drivers/block/aoe/aoe.h | 1 -
> drivers/block/aoe/aoeblk.c | 20 +++----
> drivers/block/aoe/aoedev.c | 1 -
> drivers/block/virtio_blk.c | 67 +++++++++++++---------
> drivers/nvme/host/core.c | 20 +++----
> drivers/nvme/host/lightnvm.c | 105 ++++++++++++++--------------------
> drivers/nvme/host/multipath.c | 10 +---
> drivers/nvme/host/nvme.h | 10 +---
> 8 files changed, 103 insertions(+), 131 deletions(-)
>
