On Mon, 25 Jan 2021 13:52:25 -0800, Isaac J. Manjarres wrote: > When extracting the mask for a SMR that was programmed by the > bootloader, the SMR's valid bit is also extracted and is treated > as part of the mask, which is not correct. Consider the scenario > where an SMMU master whose context is determined by a bootloader > programmed SMR is removed (omitting parts of device/driver core): > > ->iommu_release_device() > -> arm_smmu_release_device() > -> arm_smmu_master_free_smes() > -> arm_smmu_free_sme() /* Assume that the SME is now free */ > -> arm_smmu_write_sme() > -> arm_smmu_write_smr() /* Construct SMR value using mask and SID */ > > [...] Applied to will (for-joerg/arm-smmu/updates), thanks! [1/1] iommu/arm-smmu-qcom: Fix mask extraction for bootloader programmed SMRs https://git.kernel.org/will/c/dead723e6f04 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev