Re: Patch "ARM: pxa: hx4700.h: include "irqs.h" for PXA_NR_BUILTIN_GPIO" has been added to the 3.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 2, 2014 at 12:24 PM, Luis Henriques
<luis.henriques@xxxxxxxxxxxxx> wrote:
> On Tue, Apr 29, 2014 at 04:44:55PM -0700, Greg Kroah-Hartman wrote:
>>
>> This is a note to let you know that I've just added the patch titled
>>
>>     ARM: pxa: hx4700.h: include "irqs.h" for PXA_NR_BUILTIN_GPIO
>>
>> to the 3.10-stable tree which can be found at:
>>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>> The filename of the patch is:
>>      arm-pxa-hx4700.h-include-irqs.h-for-pxa_nr_builtin_gpio.patch
>> and it can be found in the queue-3.10 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@xxxxxxxxxxxxxxx> know about it.
>>
>
> I don't think this patch is actually required for the 3.10 kernel.  It
> is tagged for stable v3.13+ and since 3.10 doesn't include commit
>
>  88f718e ARM: pxa: delete the custom GPIO header
>
> it doesn't seem relevant.
>
> Note that this comment also applies to the 3.4 kernel.
>
> Cheers,
> --
> Luís

Right, this is only for stable v3.13+

See full analysis in the comments of 9928422 ARM: pxa: fix USB gadget
driver compilation regression: all goes back to 88f718e.

Regards

Andrea


>
>>
>> From c02b50e90be9f41d6802049a1a08246e9eb1a22c Mon Sep 17 00:00:00 2001
>> From: Andrea Adami <andrea.adami@xxxxxxxxx>
>> Date: Tue, 8 Apr 2014 14:53:44 +0200
>> Subject: ARM: pxa: hx4700.h: include "irqs.h" for PXA_NR_BUILTIN_GPIO
>>
>> From: Andrea Adami <andrea.adami@xxxxxxxxx>
>>
>> commit c02b50e90be9f41d6802049a1a08246e9eb1a22c upstream.
>>
>> hx4700 needs the same fix as in
>> 9705e74671f0e4f994d86b00cecf441917c64a66
>> "ARM: pxa: fix various compilation problems"
>>
>> Fix build errors. Initial one is:
>> /linux/arch/arm/mach-pxa/include/mach/hx4700.h:18:32: error:
>>  'PXA_NR_BUILTIN_GPIO' undeclared here (not in a function)
>> |  #define HX4700_ASIC3_GPIO_BASE PXA_NR_BUILTIN_GPIO
>>
>> Signed-off-by: Andrea Adami <andrea.adami@xxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>>
>> ---
>>  arch/arm/mach-pxa/include/mach/hx4700.h |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- a/arch/arm/mach-pxa/include/mach/hx4700.h
>> +++ b/arch/arm/mach-pxa/include/mach/hx4700.h
>> @@ -14,6 +14,7 @@
>>
>>  #include <linux/gpio.h>
>>  #include <linux/mfd/asic3.h>
>> +#include "irqs.h" /* PXA_NR_BUILTIN_GPIO */
>>
>>  #define HX4700_ASIC3_GPIO_BASE       PXA_NR_BUILTIN_GPIO
>>  #define HX4700_EGPIO_BASE    (HX4700_ASIC3_GPIO_BASE + ASIC3_NUM_GPIOS)
>>
>>
>> Patches currently in stable-queue which might be from andrea.adami@xxxxxxxxx are
>>
>> queue-3.10/arm-pxa-hx4700.h-include-irqs.h-for-pxa_nr_builtin_gpio.patch
>> --
>> To unsubscribe from this list: send the line "unsubscribe stable" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]