This is a note to let you know that I've just added the patch titled
usb: musb: fix PHY power on/off
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-musb-fix-phy-power-on-off.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 3063a12be2b07c64e9802708a19489342e64c1a3 Mon Sep 17 00:00:00 2001
From: Felipe Balbi <balbi@xxxxxx>
Date: Fri, 28 Mar 2014 14:31:47 -0500
Subject: usb: musb: fix PHY power on/off
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Felipe Balbi <balbi@xxxxxx>
commit 3063a12be2b07c64e9802708a19489342e64c1a3 upstream.
commi 30a70b0 (usb: musb: fix obex in g_nokia.ko
causing kernel panic) removed phy_power_on()
and phy_power_off() calls from runtime PM callbacks
but it failed to note that the driver depended
on pm_runtime_get_sync() calls to power up the PHY,
thus leaving some platforms without any means to
have a working PHY.
Fix that by enabling the phy during omap2430_musb_init()
and killing it in omap2430_musb_exit().
Fixes: 30a70b0 (usb: musb: fix obex in g_nokia.ko causing kernel panic)
Cc: Pali Rohár <pali.rohar@xxxxxxxxx>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@xxxxxxxxx>
Reported-by: Michael Scott <hashcode0f@xxxxxxxxx>
Tested-by: Michael Scott <hashcode0f@xxxxxxxxx>
Tested-by: Stefan Roese <sr@xxxxxxx>
Reported-by: Rabin Vincent <rabin@xxxxxx>
Signed-off-by: Felipe Balbi <balbi@xxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/usb/musb/omap2430.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -416,6 +416,7 @@ static int omap2430_musb_init(struct mus
omap_musb_set_mailbox(glue);
phy_init(musb->phy);
+ phy_power_on(musb->phy);
pm_runtime_put_noidle(musb->controller);
return 0;
@@ -478,6 +479,7 @@ static int omap2430_musb_exit(struct mus
del_timer_sync(&musb_idle_timer);
omap2430_low_level_exit(musb);
+ phy_power_off(musb->phy);
phy_exit(musb->phy);
return 0;
Patches currently in stable-queue which might be from balbi@xxxxxx are
queue-3.14/usb-dwc3-fix-wrong-bit-mask-in-dwc3_event_devt.patch
queue-3.14/usb-musb-fix-phy-power-on-off.patch
queue-3.14/usb-phy-am335x-control-wait-1ms-after-power-up-transitions.patch
queue-3.14/usb-musb-avoid-null-pointer-dereference.patch
queue-3.14/usb-dwc3-fix-randconfig-build-errors.patch
queue-3.14/usb-gadget-zero-fix-superspeed-enumeration-for-alternate-setting-1.patch
queue-3.14/arm-dts-am33xx-correcting-dt-node-unit-address-for-usb.patch
queue-3.14/usb-gadget-atmel_usba-fix-crashed-during-stopping-when-debug-is-enabled.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html