On Mon, Jan 25, 2021 at 07:58:29PM +0100, Pavel Machek wrote: > Hi! > > > From: Anthony Iliopoulos <ailiop@xxxxxxxx> > > > > [ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ] > > > > The integrity target relies on skcipher for encryption/decryption, but > > certain kernel configurations may not enable CRYPTO_SKCIPHER, leading to > > compilation errors due to unresolved symbols. Explicitly select > > CRYPTO_SKCIPHER for DM_INTEGRITY, since it is unconditionally dependent > > on it. > > There is no such config option in 4.19. This patch is not suitable > here. > > grep -r CRYPTO_SKCIPHER . > ./include/crypto/skcipher.h:#ifndef _CRYPTO_SKCIPHER_H > ./include/crypto/skcipher.h:#define _CRYPTO_SKCIPHER_H > ./include/crypto/skcipher.h:#endif /* _CRYPTO_SKCIPHER_H */ > > Best regards, > Pavel > > > +++ b/drivers/md/Kconfig > > @@ -527,6 +527,7 @@ config DM_INTEGRITY > > select BLK_DEV_INTEGRITY > > select DM_BUFIO > > select CRYPTO > > + select CRYPTO_SKCIPHER > > select ASYNC_XOR > > ---help--- > > This device-mapper target emulates a block device that has Good catch, now dropped, thanks. greg k-h