On Fri, Jan 22, 2021 at 08:19:15PM +0800, Tan Zhongjun wrote:
> From: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>
>
> On the following call path, `sig->pkey_algo` is not assigned
> in asymmetric_key_verify_signature(), which causes runtime
> crash in public_key_verify_signature().
>
> keyctl_pkey_verify
> asymmetric_key_verify_signature
> verify_signature
> public_key_verify_signature
>
> This patch simply check this situation and fixes the crash
> caused by NULL pointer.
>
> Fixes: 215525639631 ("X.509: support OSCCA SM2-with-SM3 certificate verification")
> Reported-by: Tobias Markus <tobias@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Reviewed-and-tested-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
> Tested-by: João Fonseca <jpedrofonseca@xxxxx>
> Acked-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v5.10+
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: george.tan <tanzhongjun@xxxxxxxxxx>
> ---
> crypto/asymmetric_keys/public_key.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Why send this to us again? Is it needed somewhere we have not already
applied it to?
thanks,
greg k-h
