On Sun, Jan 17, 2021 at 12:52:28PM +0800, menglong8.dong@xxxxxxxxx wrote: > From: Menglong Dong <dong.menglong@xxxxxxxxxx> > > 'format_corename()' will splite 'core_pattern' on spaces when it is in > pipe mode, and take helper_argv[0] as the path to usermode executable. > It works fine in most cases. > > However, if there is a space between '|' and '/file/path', such as > '| /usr/lib/systemd/systemd-coredump %P %u %g', then helper_argv[0] will > be parsed as '', and users will get a 'Core dump to | disabled'. > > It is not friendly to users, as the pattern above was valid previously. > Fix this by ignoring the spaces between '|' and '/file/path'. > > Fixes: 315c69261dd3 ("coredump: split pipe command whitespace before expanding template") > Signed-off-by: Menglong Dong <dong.menglong@xxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Paul Wise <pabs3@xxxxxxxxxxxxx> > Cc: Jakub Wilk <jwilk@xxxxxxxxx> [https://bugs.debian.org/924398] > Cc: Neil Horman <nhorman@xxxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> > Link: https://lkml.kernel.org/r/5fb62870.1c69fb81.8ef5d.af76@xxxxxxxxxxxxx > Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > --- > fs/coredump.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) What is the git commit id of this, and what stable trees do you want it merged to?