On 2021/01/04 19:51, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > On Mon, Jan 04, 2021 at 06:14:41AM +0000, Damien Le Moal wrote: >> On Mon, 2020-12-28 at 12:49 +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote: >>> The patch below does not apply to the 4.19-stable tree. >>> If someone wants it applied there, or to any other stable or longterm >>> tree, then please email the backport, including the original git commit >>> id to <stable@xxxxxxxxxxxxxxx>. >>> >>> thanks, >>> >>> greg k-h >> >> Hi Greg, >> >> I sent a backported patch for 4.19-stable in reply to your email. The backport >> is identical to the one I sent separately for the 5.4-stable tree. > > It breaks the build: > > drivers/block/null_blk_zoned.c: In function ‘null_zone_init’: > drivers/block/null_blk_zoned.c:5:42: error: ‘SZ_1M’ undeclared (first use in this function) > 5 | #define MB_TO_SECTS(mb) (((sector_t)mb * SZ_1M) >> SECTOR_SHIFT) > | ^~~~~ > drivers/block/null_blk_zoned.c:27:23: note: in expansion of macro ‘MB_TO_SECTS’ > 27 | dev_capacity_sects = MB_TO_SECTS(dev->size); > | ^~~~~~~~~~~ > drivers/block/null_blk_zoned.c:5:42: note: each undeclared identifier is reported only once for each function it appears in > 5 | #define MB_TO_SECTS(mb) (((sector_t)mb * SZ_1M) >> SECTOR_SHIFT) > | ^~~~~ > drivers/block/null_blk_zoned.c:27:23: note: in expansion of macro ‘MB_TO_SECTS’ > 27 | dev_capacity_sects = MB_TO_SECTS(dev->size); > | ^~~~~~~~~~~ > > :( Unclear where I made a mistake before sending this. It was missing an include. I sent the proper patch, correctly tested this time, in reply to the above email. Thanks ! -- Damien Le Moal Western Digital Research
