On Tue, Dec 29, 2020 at 06:58:19PM +0100, Pavel Machek wrote: > Hi! > > > From: Arnd Bergmann <arnd@xxxxxxxx> > > > > [ Upstream commit dbb60031dd0c2b85f10ce4c12ae604c28d3aaca4 ] > > > > gcc -Wextra warns about a function taking an enum argument > > being called with a bool: > > > > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function 'apply_degamma_for_user_regamma': > > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1617:29: warning: implicit conversion from 'enum <anonymous>' to 'enum dc_transfer_func_predefined' [-Wenum-conversion] > > 1617 | build_coefficients(&coeff, true); > > > > It appears that a patch was added using the old calling conventions > > after the type was changed, and the value should actually be 0 > > (TRANSFER_FUNCTION_SRGB) here instead of 1 (true). > > Yeah, but 4.19 still uses bool there, so this actually introduces a > bug. > > Please drop. Now dropped, thanks. greg k-h
