Re: [PATCH 3.2] drivers: hv: additional switch to use mb() instead of smp_mb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2014-04-18 at 17:29 +0800, Qiang Huang wrote:
> commit e4af376d04b0(drivers: hv: switch to use mb() instead of smp_mb()),
> the adjustment mistakenly dropped the change in hv_ringbuffer_read,
> so add it.
> 
> Signed-off-by: Qiang Huang <h.huangqiang@xxxxxxxxxx>

Thanks, I've added this to the queue.

Ben.

> ---
>  drivers/hv/ring_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
> index 810658e..d01edf3 100644
> --- a/drivers/hv/ring_buffer.c
> +++ b/drivers/hv/ring_buffer.c
> @@ -485,7 +485,7 @@ int hv_ringbuffer_read(struct hv_ring_buffer_info *inring_info, void *buffer,
>  	/* Make sure all reads are done before we update the read index since */
>  	/* the writer may start writing to the read area once the read index */
>  	/*is updated */
> -	smp_mb();
> +	mb();
> 
>  	/* Update the read index */
>  	hv_set_next_read_location(inring_info, next_read_location);
> -- 1.8.2.2
> 

-- 
Ben Hutchings
Q.  Which is the greater problem in the world today, ignorance or apathy?
A.  I don't know and I couldn't care less.

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]