On Sun, Dec 27, 2020 at 12:12:00PM -0800, Linus Torvalds wrote:
> On Sun, Dec 27, 2020 at 11:05 AM Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Sun, Dec 27, 2020 at 10:39 AM Jussi Kivilinna <jussi.kivilinna@xxxxxx> wrote:
> > >
> > > 5.10.3 with patch compiles fine, but does not solve the issue.
> >
> > Duh. adding the read_iter only fixes kernel_read(). For splice, it also needs a
> >
> > .splice_read = generic_file_splice_read,
> >
> > in the file operations, something like this...
>
> Ok, I verified that patch with the test-case in the bugzilla, and it
> seems trivially fine.
>
> So it's committed as 14e3e989f6a5 ("proc mountinfo: make splice
> available again") now.
Is there any point in not doing the same (scripted, obviously) for
all instances with .read == seq_read? IIRC, Christoph even posted
something along those lines, but it went nowhere for some reason...
