Re: [PATCH v2] selftests/vm: Fix building protection keys test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/15/2020 06:04 PM, Harish wrote:

The patch d8cbe8bfa7d tries to include a ARCH check for powerpc,
however ARCH is not defined in the Makefile before including
lib.mk. This makes test building to skip on both x86 and powerpc.
Fix the arch check by replacing it using machine type as it is
already defined and used in the test.

Fixes: d8cbe8bfa7d ("tools/testing/selftests/vm: fix build error")
Signed-off-by: Harish <harish@xxxxxxxxxxxxx>
---

-ifneq (,$(findstring $(ARCH),powerpc))
+ifneq (,$(findstring $(MACHINE),ppc64))
  TEST_GEN_FILES += protection_keys
  endif

Reviewed-by: Xingxing Su <suxingxing@xxxxxxxxxxx>

The findstring isn't really canonical, it's my fault,
you can replace findstring with filter like V1.




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux