Re: [PATCH for 4.14] speakup: Reject setting the speakup line discipline outside of speakup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 09, 2020 at 12:07:22PM +0100, Samuel Thibault wrote:
> [backport of 5.10 commit f0992098cadb4c9c6a00703b66cafe604e178fea]
> 
> Speakup exposing a line discipline allows userland to try to use it,
> while it is deemed to be useless, and thus uselessly exposes potential
> bugs. One of them is simply that in such a case if the line sends data,
> spk_ttyio_receive_buf2 is called and crashes since spk_ttyio_synth
> is NULL.
> 
> This change restricts the use of the speakup line discipline to
> speakup drivers, thus avoiding such kind of issues altogether.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: Shisong Qin <qinshisong1205@xxxxxxxxx>
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> Tested-by: Shisong Qin <qinshisong1205@xxxxxxxxx>
> Link: https://lore.kernel.org/r/20201129193523.hm3f6n5xrn6fiyyc@function
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Both of these worked, thanks!

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux