On 2014/4/22 23:30, Ben Hutchings wrote: > On Tue, 2014-04-22 at 15:21 +0800, Rui Xiang wrote: >> From: Ley Foon Tan <lftan@xxxxxxxxxx> >> >> commit e06c93cacb82dd147266fd1bdb2d0a0bd45ff2c1 upstream. >> >> Add support for Altera 8250/16550 compatible serial port. >> >> Signed-off-by: Ley Foon Tan <lftan@xxxxxxxxxx> >> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> [xr: Backported to 3.4: adjust filenames, context] >> Signed-off-by: Rui Xiang <rui.xiang@xxxxxxxxxx> > [...] >> --- a/include/linux/serial_core.h >> +++ b/include/linux/serial_core.h >> @@ -47,7 +47,10 @@ >> #define PORT_U6_16550A 19 /* ST-Ericsson U6xxx internal UART */ >> #define PORT_TEGRA 20 /* NVIDIA Tegra internal UART */ >> #define PORT_XR17D15X 21 /* Exar XR17D15x UART */ >> -#define PORT_MAX_8250 21 /* max port ID */ >> +#define PORT_ALTR_16550_F32 26 /* Altera 16550 UART with 32 FIFOs */ >> +#define PORT_ALTR_16550_F64 27 /* Altera 16550 UART with 64 FIFOs */ >> +#define PORT_ALTR_16550_F128 28 /* Altera 16550 UART with 128 FIFOs */ >> +#define PORT_MAX_8250 28 /* max port ID */ >> >> /* >> * ARM specific type numbers. These are not currently guaranteed > > I think that if you make gaps in the numbering of 8250 port types then > you'll need something like my commit 025f690b5b6e. I'm not sure whether > you already covered that. > Yeah, I think I'd really missed something. It would be reasonable to backport those patch by the order: 6521d6734943 8250/16?50: Add support for Broadcom TruManage redirected serial port 025f690b5b6e(3.2.y) 8250: use correct value for PORT_BRCM_TRUMANAGE e06c93cacb82 tty/serial: Add support for Altera serial port And thanks for your suggestion. I'll send them again. Thanks, Rui -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html