Re: [PATCH 3/3] 8250/16?50: Add support for Broadcom TruManage redirected serial port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2014-04-22 at 15:21 +0800, Rui Xiang wrote:
> From: Stephen Hurd <shurd@xxxxxxxxxxxx>
> 
> commit ebebd49a8eab5e9aa1b1f8f1614ccc3c2120f886 upstream.
> 
> Add support for the UART device present in Broadcom TruManage capable
> NetXtreme chips (ie: 5761m 5762, and 5725).
> 
> This implementation has a hidden transmit FIFO, so running in single-byte
> interrupt mode results in too many interrupts.  The UART_CAP_HFIFO
> capability was added to track this.  It continues to reload the THR as long
> as the THRE and TSRE bits are set in the LSR up to a specified limit (1024
> is used here).
> 
> Signed-off-by: Stephen Hurd <shurd@xxxxxxxxxxxx>
> Signed-off-by: Michael Chan <mchan@xxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> [xr: Backported to 3.4:
>  - Adjust filenames
>  - Adjust context
>  - RT_BRCM_TRUMANAGE is 25 not 24]
[...]

So you've folded in this fix:

commit 85f024401bf80746ae08b7fd5809a9b16accf0b1
Author: Michael Chan <mchan@xxxxxxxxxxxx>
Date:   Tue Jan 29 17:54:44 2013 -0800

    serial_core: Fix type definition for PORT_BRCM_TRUMANAGE.
    
    It was mistakenly defined to be 24 instead of the next higher number 25.

which perhaps should be listed in the commit message.

Ben.

-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]