Re: [PATCH v4.4] powerpc/uaccess-flush: fix corenet64_smp_defconfig build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 23, 2020 at 01:58:22PM +1100, Daniel Axtens wrote:
> Gunter reports problems with the corenet64_smp_defconfig:
> 
> In file included from arch/powerpc/kernel/ppc_ksyms.c:10:0:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:11:29: error: redefinition of ‘allow_user_access’
>  static __always_inline void allow_user_access(void __user *to, const void __user *from,
> 			     ^~~~~~~~~~~~~~~~~
> In file included from arch/powerpc/include/asm/uaccess.h:12:0,
> 		 from arch/powerpc/kernel/ppc_ksyms.c:8:
> arch/powerpc/include/asm/kup.h:12:20: note: previous definition of ‘allow_user_access’ was here
>  static inline void allow_user_access(void __user *to, const void __user *from,
> 		    ^~~~~~~~~~~~~~~~~
> 
> This is because ppc_ksyms.c imports asm/book3s/64/kup-radix.h guarded by
> CONFIG_PPC64, rather than CONFIG_PPC_BOOK3S_64 which it should do.
> 
> Fix it.
> 
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Daniel Axtens <dja@xxxxxxxxxx>
> ---
>  arch/powerpc/kernel/ppc_ksyms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

All 3 fixes now queued up, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux