On Sat, Apr 19, 2014 at 01:08:46AM +0800, Lai Jiangshan wrote:
> On Sat, Apr 19, 2014 at 12:29 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> > Hello,
>
> Hi,
>
> Should I resend the patch with your updated changelog?
> Or something else I need to do?
Yeah, please resend with the description updated.
> >> static void test5(void)
> >> {
> >> int id;
> >> DEFINE_IDR(test_idr);
> >> #define TEST5_START ((1<<27)+42) /* use the highest layer */
> >>
> >> printk(KERN_INFO "Start test5\n");
> >> id = idr_alloc(&test_idr, (void *)1, TEST5_START, 0, GFP_KERNEL);
> >> BUG_ON(id != TEST5_START);
> >> TEST_BUG_ON(idr_replace(&test_idr, (void *)2, TEST5_START) != (void *)1);
> >> idr_destroy(&test_idr);
> >> printk(KERN_INFO "End of test5\n");
> >> }
>
> Does the above testing code need to be kept in the changelog.
Yeah, why not? It makes what's failing very clear.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html