Yes, probably a good idea.
Acked-by: Corey Minyard <cminyard@xxxxxxxxxx>
On 04/18/2014 04:07 AM, Jiri Slaby wrote:
> This patch has been added to the 3.12 stable tree. If you have any
> objections, please let us know.
>
> ===============
>
> commit a94cdd1f4d30f12904ab528152731fb13a812a16 upstream.
>
> In read_all_bytes, we do
>
> unsigned char i;
> ...
> bt->read_data[0] = BMC2HOST;
> bt->read_count = bt->read_data[0];
> ...
> for (i = 1; i <= bt->read_count; i++)
> bt->read_data[i] = BMC2HOST;
>
> If bt->read_data[0] == bt->read_count == 255, we loop infinitely in the
> 'for' loop. Make 'i' an 'int' instead of 'char' to get rid of the
> overflow and finish the loop after 255 iterations every time.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Reported-and-debugged-by: Rui Hui Dian <rhdian@xxxxxxxxxx>
> Cc: Tomas Cech <tcech@xxxxxxx>
> Cc: Corey Minyard <minyard@xxxxxxx>
> Cc: <openipmi-developer@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> ---
> drivers/char/ipmi/ipmi_bt_sm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c
> index a22a7a502740..8156cafad11a 100644
> --- a/drivers/char/ipmi/ipmi_bt_sm.c
> +++ b/drivers/char/ipmi/ipmi_bt_sm.c
> @@ -352,7 +352,7 @@ static inline void write_all_bytes(struct si_sm_data *bt)
>
> static inline int read_all_bytes(struct si_sm_data *bt)
> {
> - unsigned char i;
> + unsigned int i;
>
> /*
> * length is "framing info", minimum = 4: NetFn, Seq, Cmd, cCode.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html