Hi, On 11/14/20 12:03 PM, Hans de Goede wrote: > Hi, > > On 11/12/20 4:49 PM, Benjamin Tissoires wrote: >> On Wed, Nov 11, 2020 at 12:07 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > <snip> > >>>> If so, I can try to push it later today or tomorrow. >>> >>> Sounds good, thank you. >> >> I have now applied the 3 patches to the for-5.10/upstream-fixes branch. >> I also added the Fixes tag to the first commit only. > > Great thank you. > > <snip> > >>>> Yeah, the Dinovo Mini will come later. > > So I've been working on this today and I hope to have a patch for you > ready to test soon. So no need for you to spend time on this now, > that would just be us doing double work. > > <snip> > >>> Do the original HID descriptors of the receiver perhaps have both a report 2 and >>> a report 5 and we should add both ? >> >> No, I think it only has report ID 5. > > So I checked and there are actually both INPUT(2) and INPUT(5) descriptors > on the mouse USB-device's HID intf. > > And looking at the USB ids again, this is not new vs old. This is Dinovo > vs non Dinovo. It seems that even though the air protocol is the same, > the Dinovo receivers have some special handling for the kbd touchpad where > as the non Dinovo receivers just send the same HID reports as for the normal > mouse. > > I paired both the Dinovo Edge + a BT mouse (you can pair any BT mouse, > just press the pair button on the receiver and then on the mouse) with: > > 1. The MX5000 receiver as the RH bugzilla reporter is doing > > In this case both the kbd-touchpad and the actual mouse send INPUT(2) > reports (there is no INPUT(5) in the descriptors). > > 2. The Dinovo Edge receiver. In this case the kbd-touchpad sends > INPUT(5) reports where as the actual mouse sends INPUT(2) reports. p.s. There being 2 mouse reports on the mouse intf. also explains why the hid-logitech-lg.c code needs the special LG_DUPLICATE_USAGES for the Dinovo receivers. We won't have this issue in the logitech-dj code since there (with the patch I'm working on) the INPUT(5) reports will be send to the keyboard hidpp-device where as the INPUT(2) reports will keep being send to the mouse hidpp-device as usual. So there will not be a single hidpp device which receives both mouse-reports and thus no need for something like the LG_DUPLICATE_USAGES quirk. Regards, Hans
