On Fri, Nov 6, 2020 at 12:19 AM Coiby Xu <coiby.xu@xxxxxxxxx> wrote: > Debounce filter setting should be independent from IRQ type setting > because according to the ACPI specs, there are separate arguments for > specifying debounce timeout and IRQ type in GpioIo() and GpioInt(). > > This will fix broken touchpads for laptops whose BIOS set the debounce > timeout to a relatively large value. For example, the BIOS of Lenovo > Legion-5 AMD gaming laptops including 15ARH05 (R7000) and R7000P set > the debounce timeout to 124.8ms. This led to the kernel receiving only > ~7 HID reports per second from the Synaptics touchpad > (MSFT0001:00 06CB:7F28). Existing touchpads like [1][2] are not troubled > by this bug because the debounce timeout has been set to 0 by the BIOS > before enabling the debounce filter in setting IRQ type. > > [1] https://github.com/Syniurge/i2c-amd-mp2/issues/11#issuecomment-721331582 > [2] https://forum.manjaro.org/t/random-short-touchpad-freezes/30832/28 > > Cc: Hans de Goede <hdegoede@xxxxxxxxxx> > Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1887190 > Link: https://lore.kernel.org/linux-gpio/CAHp75VcwiGREBUJ0A06EEw-SyabqYsp%2Bdqs2DpSrhaY-2GVdAA%40mail.gmail.com/ > Signed-off-by: Coiby Xu <coiby.xu@xxxxxxxxx> As I have applied patches 1-3 we only have this one to land. If Andy or someone else needs to take it through the ACPI tree you can add my: Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> If I should apply it or if Andy sends me a pull request, just ping me and tell me what to do :) Yours, Linus Walleij
