Sorry for confusing. I am really new to kernel community! I should just add the tag 'Cc: <stable@xxxxxxxxxxxxxxx>' , not really cc to stable@xxxxxxxxxxxxxxx sorry for this! Best Regards! Aili Yao > -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, November 10, 2020 5:19 PM > To: yaoaili126@xxxxxxx > Cc: yaoaili <yaoaili@xxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] ACPI, APEI, Fix error return value in > apei_map_generic_address() > > On Tue, Nov 10, 2020 at 12:29:42AM -0800, yaoaili126@xxxxxxx wrote: > > From: Aili Yao <yaoaili@xxxxxxxxxxxx> > > > > >From commit 6915564dc5a8 ("ACPI: OSL: Change the type of > > acpi_os_map_generic_address() return value"), > > acpi_os_map_generic_address() will return logical address or NULL for > > error, but for ACPI_ADR_SPACE_SYSTEM_IO case, it should be also return > > 0, as it's a normal case, but now it will return -ENXIO. so check it > > out for such case to avoid einj module initialization fail. > > > > Fixes: 6915564dc5a8 ("ACPI: OSL: Change the type of > > acpi_os_map_generic_address() return value") > > Cc: <stable@xxxxxxxxxxxxxxx> > > Reviewed-by: James Morse <james.morse@xxxxxxx> > > Tested-by: Tony Luck <tony.luck@xxxxxxxxx> > > Signed-off-by: Aili Yao <yaoaili@xxxxxxxxxxxx> > > --- > > drivers/acpi/apei/apei-base.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > I'm confused as to what you are asking us to do with this patch? Have you > read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly? > > thanks, > > greg k-h