On Wed, Oct 28, 2020 at 10:38:18AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Oct 26, 2020 at 11:43:06AM +0100, Johan Hovold wrote:
> > The driver must not call tty_wakeup() while holding its private lock as
> > line disciplines are allowed to call back into write() from
> > write_wakeup(), leading to a deadlock.
> >
> > Also remove the unneeded work struct that was used to defer wakeup in
> > order to work around a possible race in ancient times (see comment about
> > n_tty write_chan() in commit 14b54e39b412 ("USB: serial: remove
> > changelogs and old todo entries")).
> >
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > ---
> > drivers/usb/serial/digi_acceleport.c | 45 ++++++++--------------------
> > 1 file changed, 13 insertions(+), 32 deletions(-)
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Thanks for the review. Applied for -next along with the cleanup patch.
Johan
