Re: [PATCH] x86/efi: Correct EFI boot stub use of code32_start

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 15, 2014 at 05:53:55PM +0100, Matt Fleming wrote:
> On Tue, 15 Apr, at 05:47:37PM, Matt Fleming wrote:
> > commit 7e8213c1f3acc064aef37813a39f13cbfe7c3ce7 upstream.
> > 
> > code32_start should point at the start of the protected mode code, and
> > *not* at the beginning of the bzImage. This is much easier to do in
> > assembly so document that callers of make_boot_params() need to fill out
> > code32_start.
> > 
> > The fallout from this bug is that we would end up relocating the image
> > but copying the image at some offset, resulting in what appeared to be
> > memory corruption.
> > 
> > Reported-by: Thomas Bächler <thomas@xxxxxxxxxxxxx>
> > Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx>
> 
> Urgh, sorry Greg. I somehow messed up the author field when creating
> this patch - it should be from my Intel address.
> 
> Are you able to fix this up, or would you just like me to resubmit?

I'll take the address that is in the original commit :)

What kernel version(s) are you wanting these backported to?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]