On Fri, 30 Oct 2020 14:29:32 +0000 Robin Murphy <robin.murphy@xxxxxxx> wrote: > On 2020-10-30 10:53, Boris Brezillon wrote: > [...] > > + /* Schedule a reset if there's no reset in progress. */ > > + if (!atomic_cmpxchg(&pfdev->reset.pending, 0, 1)) > > Nit: this could just be a simple xchg with 1 - you don't need the > compare aspect, since setting it to true when it was already true is > still harmless ;) Yep, I'll post a new version using atomic_xchg() here. Thanks, Boris