Re: [PATCH 4.4-5.9] efivarfs: Replace invalid slashes with exclamation marks in dentries.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 29, 2020 at 01:20:06PM -0600, dann frazier wrote:
> On Thu, Oct 29, 2020 at 1:18 PM Greg KH <greg@xxxxxxxxx> wrote:
> >
> > On Thu, Oct 29, 2020 at 11:54:42AM -0600, dann frazier wrote:
> > > From: Michael Schaller <misch@xxxxxxxxxx>
> > >
> > > commit 336af6a4686d885a067ecea8c3c3dd129ba4fc75 upstream
> > >
> > > Without this patch efivarfs_alloc_dentry creates dentries with slashes in
> > > their name if the respective EFI variable has slashes in its name. This in
> > > turn causes EIO on getdents64, which prevents a complete directory listing
> > > of /sys/firmware/efi/efivars/.
> > >
> > > This patch replaces the invalid shlashes with exclamation marks like
> > > kobject_set_name_vargs does for /sys/firmware/efi/vars/ to have consistently
> > > named dentries under /sys/firmware/efi/vars/ and /sys/firmware/efi/efivars/.
> > >
> > > Signed-off-by: Michael Schaller <misch@xxxxxxxxxx>
> > > Link: https://lore.kernel.org/r/20200925074502.150448-1-misch@xxxxxxxxxx
> > > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> >
> > Any reason you are not signing off on this?
> 
> No, sorry:
> 
> Signed-off-by: dann frazier <dann.frazier@xxxxxxxxxxxxx>
> 
> Easier if I send a v2?

Nah, I can take that, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux