On Sun, Apr 13, 2014 at 9:50 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Sun, Apr 13, 2014 at 09:41:08PM +0800, Shuduo Sang wrote: >> On Sat, Apr 12, 2014 at 11:05 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >> > On Sat, Apr 12, 2014 at 03:26:41PM +0800, Shuduo Sang wrote: >> >> On Fri, Apr 11, 2014 at 11:44 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >> >> > On Fri, Apr 11, 2014 at 11:33:41PM +0800, Shuduo Sang wrote: >> >> >> Hi stable tree maintainer, >> >> >> >> >> >> Pls backport two patches for Thinkpad X1 carbon 2nd generation's fancy >> >> >> adaptive keyboard: >> >> >> >> >> >> 330947b84382479459e5296a0024c670367b0b57 save and restore adaptive >> >> >> keyboard mode for suspend and resume >> >> >> >> >> >> 3a9d20bda1d6daae9d81a4cc4cc67238c5574d31 support Thinkpad X1 Carbon >> >> >> 2nd generation's adaptive keyboard >> >> > >> >> > That's a really "big" patch for a stable kernel, do you think it matches >> >> > the Documentation/stable_kernel_rules.txt rules? >> >> > >> >> >> >> Above patches are well tested on Ubuntu 14.04 Beta with 3.13 kernel and Debian >> >> with Linus tree. >> >> >> >> Sorry 3a9d20bda1d6daae9d81a4cc4cc67238c5574d31 is about 150 lines. >> >> But it's fundamental to initially support adaptive keyboard. It's hard to split. >> > >> > It looks like this is a "support new hardware" request, which doesn't >> > happen in stable kernel releases, unless it is just a "simple" quirk or >> > device id addition. At 150 lines, that does not meet these rules, >> > sorry. >> >> Sorry X1 carbon's adaptive keyboard has so rich functions that need >> 150 lines code >> to support. It can't be simple quirk or only new id. Is it possible to >> be accepted if the >> patch be split to two patches less 150 lines? > > So, you want to game the system? No, we don't add new hardware support > to old kernels, that's not what the stable kernel releases are about. > >> If stable tree has no these patches, some linux users who purchased X1 carbon >> need hack kernel by themselves to make the fancy adaptive keyboard >> working. I know >> many X1 carbon's users are suffering on it. > > Then just use a new kernel version. Or get your distro to backport the > patch. Or even better, run your own kernel with the patch in it. > > What makes this keyboard so special from the thousands of other new > devices we support with every new kernel? The rules about what we > accept into the stable kernels are there for a reason. That's okay. Thanks for you explain. > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html