On Thu, 2020-10-22 at 09:55 -0400, M. Vefa Bicakci wrote: > From: Bastien Nocera <hadess@xxxxxxxxxx> > > From: Bastien Nocera <hadess@xxxxxxxxxx> > > Contrary to the comment above the id table, we didn't implement a > match > function. This meant that every single Apple device that was already > plugged in to the computer would have its device driver reprobed > when the apple-mfi-fastcharge driver was loaded, eg. the SD card > reader > could be reprobed when the apple-mfi-fastcharge after pivoting root > during boot up and the module became available. > > Make sure that the driver probe isn't being run for unsupported > devices by adding a match function that checks the product ID, in > addition to the id_table checking the vendor ID. > > Fixes: 249fa8217b84 ("USB: Add driver to control USB fast charge for > iOS devices") > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> > Reported-by: Pany <pany@xxxxxxxxxxxxxxxxx> > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1878347 > Link: > https://lore.kernel.org/linux-usb/CAE3RAxt0WhBEz8zkHrVO5RiyEOasayy1QUAjsv-pB0fAbY1GSw@xxxxxxxxxxxxxx/ > Cc: <stable@xxxxxxxxxxxxxxx> # 5.8 > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > [m.v.b: Add Link and Reported-by tags to the commit message] > Signed-off-by: M. Vefa Bicakci <m.v.b@xxxxxxxxxx> And along with the 1/2 patch: Tested-by: Bastien Nocera <hadess@xxxxxxxxxx>