On Thu, Oct 15, 2020 at 02:11:17PM +0000, Deucher, Alexander wrote: > [AMD Public Use] > > > -----Original Message----- > > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > > Sent: Thursday, October 15, 2020 10:06 AM > > To: Deucher, Alexander <Alexander.Deucher@xxxxxxx> > > Cc: Alex Deucher <alexdeucher@xxxxxxxxx>; stable@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH] Revert "drm/amdgpu: Fix NULL dereference in dpm > > sysfs handlers" > > > > On Thu, Oct 15, 2020 at 01:18:34PM +0000, Deucher, Alexander wrote: > > > [AMD Public Use] > > > > > > > -----Original Message----- > > > > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > Sent: Thursday, October 15, 2020 1:15 AM > > > > To: Alex Deucher <alexdeucher@xxxxxxxxx> > > > > Cc: stable@xxxxxxxxxxxxxxx; Deucher, Alexander > > > > <Alexander.Deucher@xxxxxxx> > > > > Subject: Re: [PATCH] Revert "drm/amdgpu: Fix NULL dereference in dpm > > > > sysfs handlers" > > > > > > > > On Wed, Oct 14, 2020 at 04:28:36PM -0400, Alex Deucher wrote: > > > > > This regressed some working configurations so revert it. Will fix > > > > > this properly for 5.9 and backport then. > > > > > > > > What do you mean "backport then"? > > > > > > > > > > > > > > This reverts commit 38e0c89a19fd13f28d2b4721035160a3e66e270b. > > > > > > > > > > This needs to be applied to 5.9 as well. -next (5.10) has this > > > > > already, but 5.9 missed it. > > > > > > > > What is the real fix for this? Is it in Linus's tree and I can just > > > > backport that fix? > > > > > > > > > > This is no real fix. The revert is the fix. Sorry, I should have clarified that. > > > > Is it also reverted in Linus's tree? If so, what's that commit id? > > > > If not, shouldn't it be? > > It is reverted in Linus' tree. I cherry-picked the revert from Linus' tree: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=87004abfbc27261edd15716515d89ab42198b405 Ok, I've queued that one up now, can you also send me versions of this for the older kernel trees that need it (I think 4.19.y and 5.4.y). thanks, greg k-h
