Re: [PATCH 1/1] drm/syncobj: Fix drm_syncobj_handle_to_fd refcount leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 06, 2020 at 02:52:28PM +0100, Giuliano Procida wrote:
> commit e7cdf5c82f1773c3386b93bbcf13b9bfff29fa31 upstream.

That's not what this commit is :(

Are you sure this is correct?

> The cherry-pick 5fb252cad61f of the above commit introduced a refcount
> imbalance and so leak of struct drm_syncobj objects that can be
> triggered with DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD.

Ok, so the backport of e7cdf5c82f1773c3386b93bbcf13b9bfff29fa31 is the
problem, so this needs a bit of wording change to make it obvious what
is happening here.

Can you fix that up and resend?

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux