Le 26/09/2020 à 19:32, Linus Torvalds a écrit :
The explanations here do not make sense.
On Fri, Sep 25, 2020 at 9:19 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
There are 2 issues here:
a. The sysfs memory and node's layouts are broken due to these multiple
links
b. The link errors in link_mem_sections() should not lead to a system
panic.
To address a. register_mem_sect_under_node should not rely on the system
state to detect whether the link operation is triggered by a hot plug
operation or not. This is addressed by the patches 1 and 2 of this series.
The patch 3 is addressing the point b.
This patch (of 2):
The memmap_context enum is used to detect whether a memory operation is due
to a hot-add operation or happening at boot time.
Make it general to the hotplug operation and rename it as meminit_context.
There is no functional change introduced by this patch
So far so good.
But there is no "patch 3" that addresses point (b) in this series.
I see it on lore, but it's not part of what actually got sent to me,
so the commit message for patch 1 now makes no sense any more.
I agree, the commit description is a bit confusing now.
I think the Andrew's idea was to queue up the 2 first patches which are
cc:stable to the 5.9-rcX and later the third one which is not really fixing an
issue. The BUG_ON is unlikely to be triggered once the 2 first patches are applied.
Thanks,
Laurent.
